Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Posted by Bob Prestridge
Bob Prestridge
8,400 Points

Object-oriented Python: why isn't this working?

I have been working on code for this challenge:

Let's practice using @classmethod!

Create a class method in Letter named from_string that takes a string like "dash-dot" and creates an instance with the correct pattern (['_', '.']).

I have been using this code; I don't understand why I can't pass this challenge:

@classmethod def from_string(cls, string): list = string.split('-') dot_dash = [] for blip in list: if blip== 'dash': dot_dash.append('_') else: dot_dash.append('.') return cls(dot_dash)

1 Answer

Steven Parker
Steven Parker
231,261 Points
Steven Parker
Steven Parker
231,261 Points

I can't check the indentation in unformatted code, but assuming that's all OK I see two other issues:

  • when "blip" is a "dash", an empty string is appended instead of an underscoare ('_')
  • the return statement references "dotdash" instead of "dot_dash"
Bob Prestridge
Bob Prestridge
8,400 Points

Thanks; I'll make the corrections.