Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

General Discussion

Posted by djsands
djsands
6,286 Points

so I was hoping for some feedback ... https://djsandscreation.github.io/starwarsproject1/

so I was hoping for some feedback ...

https://djsandscreation.github.io/starwarsproject1/

Ryan Groom
Ryan Groom
18,674 Points

Pretty cool, you did a lot of things very well. You implemented a lot of the HTML semantic elements, it looks fairly decent at both mobile and desktop views. You made all the links the same color which made them stand out by making it a color that differs from the rest used on the page. A few small suggestions I would make (keep in mind these are just my opinions) would be to limit the amount of colors you use. It looks like you have 3 different shades of blue for text colors. One other small suggestion I would make would be to add a hover state to your links. This will give them another sign that they are clickable. You could increase/reduce the opacity on hover. This is a good way to make a subtle change that isn't too crazy or distracting. Overall great work though!

1 Answer

djsands
djsands
6,286 Points
djsands
djsands
6,286 Points

Thanks, that's very useful feedback.