The challenge says that my implementation is off but when I tested it locally using node.js, it works anyway.

Question

I did everything it says on the challenge and tested my code locally (which works) but it doesn't seem to accept it.

index.js

var utilities = require("./utilities.js");

var mailValues = {};

mailValues.first_name = "Janet";

var emailTemplate = "Hi %first_name%! Thanks for completing this code challenge :)";

var mergedContent = utilities.merge(emailTemplate, mailValues);

//mergedContent === "Hi Janet! Thanks for completing this code challenge :)";

utilities.js

function merge(content, values) {
  content = content.replace('%first_name%', values.first_name);
  return content;
}


module.exports.merge = merge;

Answer 1 · 2019-03-13T12:45:06Z

March 13, 2019 12:45pm

I can see that your code will handle the sample that only replaces "first_name", but the challenge is asking for a function that would be able to handle larger value sets with different token names as well. I'm sure the validator is testing it with different data from the sample.

Hints: You'll probably need a loop, and don't hard-code any property names.

Answer 2 · 2019-06-19T00:43:04Z

June 19, 2019 12:43am

function merge(content, values) {
    for(var key in values) {
        // replace all key with the value from the values object
        content = content.replace("%" + key +"%", values[key]);
    }

  return content;
}


module.exports.merge = merge;

this will complete the challenge. I wish they always had challenge completions up so you can actively double check your work must faster. There is technically no cheating on treehouse.

Welcome to the Treehouse Community

Looking to learn something new?

Nathaniel Saludes

Nathaniel Saludes

The challenge says that my implementation is off but when I tested it locally using node.js, it works anyway.

2 Answers

Steven Parker

Steven Parker

Nathaniel Saludes

Nathaniel Saludes

Thomas Tilton-Heylin

Thomas Tilton-Heylin

Steven Parker

Steven Parker