Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Connor McKenzie
Connor McKenzie
9,992 Points

This code seems to work when I log the output in a workplace window but doesn't pass the challenge and I'm not sure why?

This code seems to work when I log the output in a workplace window but doesn't pass the challenge and I'm not sure why?

creating_setters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

  set major(major){
    if(this.level === 'Junior ' || this.level === 'Senior '){
      this._major = major;
    } else if(this.level === 'Sophomore ' || this.level === 'Freshman  '){
      this._major = 'None';
    }
  }
}

var student = new Student(3.9, 60);

1 Answer

Martin Balon
Martin Balon
43,651 Points

Hi Connor,

In your set method in if and else if condition you have always empty space after Junior, Senior etc.. Try deleting these empty spaces and see if it works.

Connor McKenzie
Connor McKenzie
9,992 Points

Thanks Martin! That's what it was haha, simple mistakes eh