Tip: use the negation operator

Question

To change the players active state property use the negation operator like this:

switchPlayers() {
        this.players[0].active = !this.players[0].active;
        this.players[1].active = !this.players[1].active;
    }

instead of the for-loop and the ternary operator. Why would we ever have more than 2 player in four-in-a-row? (irony)

Answer 1 · 2018-09-09T17:00:33Z

September 9, 2018 5:00pm

One of the great things with code is that there are often more than one solution. I also opted for another solution than the ternary operator, simply because I think it is complicated to read. But in the spirit of keeping my code dry, I kept the for-loop and ended with the following solution:

switchPlayers(){
    for (let player of this.players) {
      player.active = !player.active;
    }
  }

It is short and easy to read. I do get your point that a for-loop may be a bit overkill when there are only two objects, but to be honest, I disagree...

Answer 2 · 2019-05-16T11:01:55Z

May 16, 2019 11:01am

I had the same approach but with forEach() rather than for..of:

switchPlayers() {
    this.players.forEach(player => player.active = !player.active);
}

Welcome to the Treehouse Community

Looking to learn something new?

Hakim Rachidi

Hakim Rachidi

Tip: use the negation operator

2 Answers

Heidi Puk Hermann

Heidi Puk Hermann

Gabbie Metheny

Gabbie Metheny

Andrew Federico

Andrew Federico

thomas shellberg

thomas shellberg

Joe Elliot

Joe Elliot

George Roberts

George Roberts