Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialTara Edwards
6,521 PointsWhat am I missing? Error message in complier
My quest is two-part. One, I am not sure how to install a runtime machine in IntelliJ. If I was able to, I would have been able to catch this error. When I pasted in the code, I got this error: ./com/teamtreehouse/KaraokeMachine.java:144: error: cannot find symbol songRequest.getSinger(), ^ symbol: method getSinger() location: variable songRequest of type SongRequest 1 error
I think it is something small, but I am not sure what.
package com.teamtreehouse;
import com.teamtreehouse.model.Song;
import com.teamtreehouse.model.SongBook;
import com.teamtreehouse.model.SongRequest;
import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;
import java.util.ArrayDeque;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Queue;
public class KaraokeMachine {
private SongBook mSongBook;
private BufferedReader mReader;
private Queue<SongRequest> mSongRequestQueue;
private Map<String, String> mMenu;
public KaraokeMachine(SongBook songBook) {
mSongBook = songBook;
mReader = new BufferedReader(new InputStreamReader(System.in));
mSongRequestQueue = new ArrayDeque<>();
mMenu = new HashMap<String, String>();
mMenu.put("add", "Add a new song to the song book");
mMenu.put("play", "Play next song in the queue");
mMenu.put("choose", "Choose a song to sing!");
mMenu.put("quit", "Give up. Exit the program");
}
private String promptAction() throws IOException {
System.out.printf("There are %d songs available and %d in the queue. Your options are: %n",
mSongBook.getSongCount(),
mSongRequestQueue.size());
for (Map.Entry<String, String> option : mMenu.entrySet()) {
System.out.printf("%s - %s %n",
option.getKey(),
option.getValue());
}
System.out.print("What do you want to do: ");
String choice = mReader.readLine();
return choice.trim().toLowerCase();
}
public void run() {
String choice = "";
do {
try {
choice = promptAction();
switch(choice) {
case "add":
Song song = promptNewSong();
mSongBook.addSong(song);
System.out.printf("%s added! %n%n", song);
break;
case "choose":
String singerName = promptForSinger();
String artist = promptArtist();
Song artistSong = promptSongForArtist(artist);
SongRequest sRequest = new SongRequest(singerName, artistSong);
mSongRequestQueue.add(sRequest);
if (mSongRequestQueue.contains(sRequest)) {
System.out.printf("%n%n Whoops %s already requested %s",
singerName,artistSong);
break;
}
System.out.printf("You chose: %s %n", artistSong);
break;
case "play":
playNext();
break;
case "quit":
System.out.println("Thanks for playing!");
break;
default:
System.out.printf("Unknown choice: '%s'. Try again. %n%n%n",
choice);
}
} catch(IOException ioe) {
System.out.println("Problem with input");
ioe.printStackTrace();
}
} while(!choice.equals("quit"));
}
private String promptForSinger() throws IOException {
System.out.println("Enter the singer's name: ");
return mReader.readLine();
}
private Song promptNewSong() throws IOException {
System.out.print("Enter the artist's name: ");
String artist = mReader.readLine();
System.out.print("Enter the title: ");
String title = mReader.readLine();
System.out.print("Enter the video URL: ");
String videoUrl = mReader.readLine();
return new Song(artist, title, videoUrl);
}
private String promptArtist() throws IOException {
System.out.println("Available artists:");
List<String> artists = new ArrayList<>(mSongBook.getArtists());
int index = promptForIndex(artists);
return artists.get(index);
}
private Song promptSongForArtist(String artist) throws IOException {
List<Song> songs = mSongBook.getSongsForArtist(artist);
List<String> songTitles = new ArrayList<>();
for (Song song : songs) {
songTitles.add(song.getTitle());
}
System.out.printf("Available songs for %s: %n", artist);
int index = promptForIndex(songTitles);
return songs.get(index);
}
private int promptForIndex(List<String> options) throws IOException {
int counter = 1;
for (String option : options) {
System.out.printf("%d.) %s %n", counter, option);
counter++;
}
System.out.print("Your choice: ");
String optionAsString = mReader.readLine();
int choice = Integer.parseInt(optionAsString.trim());
return choice - 1;
}
public void playNext() {
SongRequest songRequest = mSongRequestQueue.poll();
if (songRequest == null) {
System.out.println("Sorry there are no songs in the queue." +
" Use choose from the menu to add some");
} else {
Song song = songRequest.getSong();
System.out.printf("%n%n%n Ready %s? Open %s to hear %s by %s %n%n%n",
songRequest.getSinger(),
song.getVideoUrl(),
song.getTitle(),
song.getArtist());
}
}
}
1 Answer
Ryan Ruscett
23,309 PointsWhats up??
Ok so you are pretty close, I wont post the whole code but the problematic code.
You problem is in here
public void playNext() {
SongRequest songRequest = mSongRequestQueue.poll();
if (songRequest == null) {
System.out.println("Sorry there are no songs in the queue." +
" Use choose from the menu to add some");
} else {
Song song = songRequest.getSong();
System.out.printf("%n%n%n Ready %s? Open %s to hear %s by %s %n%n%n",
songRequest.getSinger(),
song.getVideoUrl(),
song.getTitle(),
song.getArtist());
}
}
Ok so let's take a look at your else statement.
- if songRequest is equal to null print something
- else (HERE IS THE PROBLEM)
You are saying that Song song = songRequest.getSong() Ok so whatever "song" is, will be the song you are trying to get. Ok cool, BUT when you do System.out.print. You are saying songRequest.getSinger() It's not getting the singer but yet the song. Which you already got with song.
Like this.
public void playNext() {
SongRequest songRequest = mSongRequestQueue.poll();
if (songRequest == null) {
System.out.println("Sorry there are no songs in the queue." +
" Use choose from the menu to add some");
} else {
Song song = songRequest.getSong();
System.out.printf("%n%n%n Ready %s? Open %s to hear %s by %s %n%n%n",
songRequest.getSinger(), <----------------------CHANGE THIS to 'song'
song.getVideoUrl(),
song.getTitle(),
song.getArtist());
}
}
In the above I have outlined the error. This is the fix
public void playNext() {
SongRequest songRequest = mSongRequestQueue.poll();
if (songRequest == null) {
System.out.println("Sorry there are no songs in the queue." +
" Use choose from the menu to add some");
} else {
Song song = songRequest.getSong();
System.out.printf("%n%n%n Ready %s? Open %s to hear %s by %s %n%n%n",
song,
song.getVideoUrl(),
song.getTitle(),
song.getArtist());
}
}
}
That is what the code should look like.
Does that make sense?
Tara Edwards
6,521 PointsTara Edwards
6,521 PointsI kinda does. I will make those changes. Thanks.