Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Luis Onate
Luis Onate
13,222 Points
Posted by Luis Onate
Luis Onate
13,222 Points

Why does my code not pass the challenge (CapatilismHand Challenge, Task 2)? [Solved]

For the @property doubles, when I run my code in my terminal, it seems to return the correct boolean. I've tried to step through and think about the data and I believe my code should do the job, but I keep failing the challenge. Would someone mind giving me a second pair of eyes and let me know what I'm missing.

hands.py 
from dice import D6


class Hand(list):
    def __init__(self, size=0, die_class=None, *args, **kwargs):
        if not die_class:
            raise ValueError("You must provide a die class")
        super().__init__()

        for _ in range(size):
            self.append(die_class())
        self.sort()

    def _by_value(self, value):
        dice = []
        for die in self:
            if die == value:
                dice.append(die)
        return dice


class CapitalismHand(Hand):
    def __init__(self, *args, **kwargs):
        super().__init__(size=2, die_class=D6, *args, **kwargs)

    @property
    def doubles(self):
        count_list = []
        for worth, count in self._sets.items()
            count_list.append(count)
        return '2' in count_list

    @property
    def ones(self):
        return self._by_value(1)

    @property
    def twos(self):
        return self._by_value(2)

    @property
    def threes(self):
        return self._by_value(3)

    @property
    def fours(self):
        return self._by_value(4)

    @property
    def fives(self):
        return self._by_value(5)

    @property
    def sixes(self):
        return self._by_value(6)

    @property
    def _sets(self):
        return {
            1: len(self.ones),
            2: len(self.twos),
            3: len(self.threes),
            4: len(self.fours),
            5: len(self.fives),
            6: len(self.sixes)
        }

    @property
    def doubles(self):
        for worth, count in self._sets.items():
            if count == 2:
                return True
        return False
Luis Onate
Luis Onate
13,222 Points
Luis Onate
Luis Onate
13,222 Points

Never mind, just saw I had the property down twice, once at the beginning of the CapitalismHand class and once at the end. Problem solved, just needed a high level view of the code. Got sucked down into detailed view and didn't take a step back to look at the big picture.