Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

kevin anderson
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
kevin anderson
Front End Web Development Techdegree Graduate 41,112 Points

Why does task 1 no longer pass? Java normalization

I get task one to pass, then task 2, but error saying task 1 no longer passes???

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  private String normalizeDiscountCode (String discountCode) {

    for (char letter : discountCode.toCharArray()) {
            if ( ! Character.isLetter(letter) || letter != '$') {
            throw new IllegalArgumentException ("Invalid discount code");
            }
         }
    return discountCode.toUpperCase();

  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

2 Answers

Yanuar Prakoso
Yanuar Prakoso
15,196 Points

Hi Kevin

You need to change your IF STATEMENT from your code which is this:

if ( ! Character.isLetter(letter) || letter != '$') //<- this is wrong

//you need to change it into:
if ( ! Character.isLetter(letter) && letter != '$')

//or altenatively:
if (!( Character.isLetter(letter) || letter == '$'))

This is because the normalization of the discount code asked for specific terms of String code:

IF THE CHARATER IS NOT A LETTER OR A '$' right? meaning:

IF NOT(A LETTER OR A '$');

IF !(LETTER || '$');

Therefore because of something called De Morgan's Law you will have to change || into && if you want to distribute the negation ('!') inside the paranthesis:

IF(!LETTER && !='$');

That is all from me. I hope this can help a little.