Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Build a Simple Dynamic Site with Node.js Creating a Basic Template Engine in Node.js A Simple Merge Utility

Posted by Justin Maurer
Justin Maurer
11,056 Points

Why won't my code pass?

I'm confused about why my code won't pass. I've reproduced the code from the exercise, while replacing {{ }} with %.

Is this a bug, or am I missing something?

index.js 
var utilities = require("./utilities");

var mailValues = {};

mailValues.first_name = "Janet";

var emailTemplate = "Hi %first_name%! Thanks for completing this code challenge :)";

var mergedContent = utilities.merge(emailTemplate, mailValues);

//mergedContent === "Hi Janet! Thanks for completing this code challenge :)";
utilities.js 
function merge(content, values) {
  for (var key in values) {
    content.replace("%"+key+"%",values[key]);
  }
  return content;
}


module.exports.merge = merge;

1 Answer

Žiga Pregelj
Žiga Pregelj
18,126 Points
Žiga Pregelj
Žiga Pregelj
18,126 Points

You are almost there, just don't use var in loops, for loop it's almost always like that: for( thing in things) { do something }.

function merge(content, values) {
  for (key in values) {
    content = content.replace("%"+key+"%", values[key]);
  }
  return content;
}

module.exports.merge = merge;
Justin Maurer
Justin Maurer
11,056 Points

ahhhh thank you!